Skip to content

Commit

Permalink
fixed clang warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
aviezerl committed Nov 29, 2023
1 parent 931cd57 commit f5df51e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# naryn 2.6.25

* Fixed clang warnings.
* Fix: filter name to include operator when name is automatically generated


# naryn 2.6.24

* Allow filters names with a dot when creating an automatic virtual track name.
Expand Down
3 changes: 1 addition & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@

0 errors | 0 warnings | 0 notes

* Fixed UBSAN's memory misalignment errors.
* Since this keeps arising every submission, attached are the reasons for the unix OS requirement: The package implements a database that is based on shared memory files and therefore includes many unix-specific system calls. In addition, many parallel algorithms used in the package rely on the unix forking mechanism.
* Fixed clang warnings.
6 changes: 3 additions & 3 deletions src/naryn.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ void Naryn::handle_error(const char *msg)
}
rexit();
} else {
errorcall(R_NilValue, msg);
errorcall(R_NilValue, "%s", msg);
}
}

Expand Down Expand Up @@ -675,7 +675,7 @@ void vwarning(const char *fmt, ...)
vsnprintf(buf, sizeof(buf), fmt, ap);
va_end(ap);

Rf_warningcall_immediate(R_NilValue, buf);
Rf_warningcall_immediate(R_NilValue, "%s", buf);
}

void vdebug(const char *fmt, ...)
Expand All @@ -696,7 +696,7 @@ void vdebug(const char *fmt, ...)
TGLError("null format string");
}
va_end(ap);
REprintf(buf);
REprintf("%s", buf);

if (!*fmt || (*fmt && fmt[strlen(fmt) - 1] != '\n'))
REprintf("\n");
Expand Down

0 comments on commit f5df51e

Please sign in to comment.