write to tempfile on emr_track.var.set #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an error when multiple processes are calling `emr_track.var.set` on the same track.
aviezerl
force-pushed
the
fix@write-to-tempfile-on-emr_track.var.set
branch
from
3b3de6f
to
1cfc87f
Compare
nettam
reviewed
Sep 10, 2023
There was a problem hiding this comment.
How does this solve the problem? two procs can still try and call rename at the same time
There was a problem hiding this comment.
rename uses a system call (mv) which is atomic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error when multiple processes are calling
emr_track.var.seton the same track.