Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timezone detection and refactor Pricer #69

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Add timezone detection and refactor Pricer #69

merged 3 commits into from
Jun 3, 2024

Conversation

remkop22
Copy link
Collaborator

@remkop22 remkop22 commented Mar 21, 2024 •
edited
Loading

Fixes #19, #65

@remkop22 remkop22 self-assigned this Mar 21, 2024
@remkop22 remkop22 linked an issue Mar 21, 2024 that may be closed by this pull request
Add some extra fields to the pricer::Report type #65
Closed
basbossink-ds
basbossink-ds reviewed Mar 27, 2024
View reviewed changes
ocpi-tariffs/src/lib.rs Outdated Show resolved Hide resolved
ocpi-tariffs/src/pricer.rs Outdated Show resolved Hide resolved
basbossink-ds
basbossink-ds approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@basbossink-ds basbossink-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@remkop22 remkop22 merged commit ff429aa into main Jun 3, 2024
12 checks passed
@remkop22 remkop22 deleted the detect-timezone branch June 3, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basbossink-ds basbossink-ds basbossink-ds approved these changes

Assignees

@remkop22 remkop22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add some extra fields to the pricer::Report type Detect time-zone from country
2 participants
@remkop22 @basbossink-ds