Don't override the set ConverterFailure text

tandemdude · May 31, 2021 · 85c17d9 · 85c17d9
1 parent 0b2a3e6
commit 85c17d9
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lightbulb/commands.py b/lightbulb/commands.py
@@ -471,12 +471,15 @@ async def _convert_args(
             try:
                 new_arg = await self.handle_types(arg, details.annotation)
                 new_args.append(new_arg)
-            except (errors.ConverterFailure, ValueError):
+            except (errors.ConverterFailure, ValueError) as exc:
                 _LOGGER.error(
                     "Failed converting %s with converter: %s",
                     arg,
                     getattr(details.annotation, "__name__", repr(details.annotation)),
                 )
+                if isinstance(exc, errors.ConverterFailure) and exc.text:
+                    raise  # don't override the preset text
+
                 raise errors.ConverterFailure(
                     text=f"Failed converting {arg} with converter: {getattr(details.annotation, '__name__', repr(details.annotation))}"
                 )