-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New script to create SQL baseline from AWR and some changes in the hint.sql #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know in which DB version this V$SQL_HINT.TARGET_LEVEL column showed up? I only have access to 12.2+ right now, would be good to have this hint script not fail in 11.2 and 12.1 ...
v$sql_hint was a new feature in 11.2. Unfortunately, I don’t have any 11.2 databases left to verify but I checked on 12.1 and the column exists on 12.1 |
At least 11.2, not sure about the stuff below 11.2. Just tested it successfully on 11.2.0.1. |
11.2 support is good enough. I am even thinking of defaulting to 12.1+ support by default and people still running TPT scripts on older versions would have to comment out the fancy new columns that they don't have - or perhaps use a cloned script with "11" suffix its name, in the cases where 12c+ has a great new column that's not available in 11.2... This way I don't have to add too much dynamic complexity into these scripts. Another major piece of work (for 12c+) would be to convert the scripts from using dba_ to cdb_ views with the right container filtering logic, so that one would be able to run queries at CDB level too, but yet join to the right object names, etc in appropriate containers. I'll merge the change, thanks! |
You can create a version in github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got to reviewing this....
Since this uses dbms_sqltune, it would require tuning pack licenses... perhaps better to use DBMS_SPM.LOAD_PLANS_FROM_AWR (as my create_sql_baseline_awr.sql uses). That should still be usable in basic mode without Tuning Pack.
I'll reject that baseline addition, but will merge the hint.sql changes (useful stuff!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accepting the hint.sql changes
new columns for hint.sql |
forgot to merge before closing the PR apparently |
I changed the hint scope display column to one column:
|
No description provided.