Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix language-switching issue with containers #57

Closed
wants to merge 3 commits into from
Closed

Fix language-switching issue with containers #57

wants to merge 3 commits into from

Conversation

fmr
Copy link
Contributor

@fmr fmr commented Apr 8, 2015

When used together with template caching, switching languages with fancypages becomes slightly problematic. Each request causes containers to switch back and forth between available languages. This fix makes the container template tags a little more thread-safe, specifically with the language_code parameter, in combination with get_language from django.utils.translation.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 84.36% when pulling f1fb6fe on fmr:fix/thread_safety into eb343e8 on tangentlabs:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 84.36% when pulling 38db881 on fmr:fix/thread_safety into eb343e8 on tangentlabs:master.

@fmr fmr closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fmr @coveralls