scripts: script update must be approved #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiderpowa
force-pushed
the
jimmy-script-more
branch
from
4fed729
to
60333a0
Compare
Spiderpowa
changed the title
Spiderpowa
force-pushed
the
jimmy-script-more
branch
from
60333a0
to
ee61698
Compare
Spiderpowa
force-pushed
the
jimmy-script-more
branch
from
ee61698
to
1e6841a
Compare
aitjcize
reviewed
Oct 3, 2019
scripts/run_bp.py
Outdated
| _SCRIPT_APPROVE_PATH_TMPL = _SCRIPT_PATH + '.%s' | ||
| _SCRIPT_APPROVE_SRC_TMPL = ('https://raw.githubusercontent.com/' | ||
| '%s/%s/%%s/%s' % (_SCRIPT_ORG, _SCRIPT_REPO, _SCRIPT_APPROVE_PATH_TMPL)) | ||
| _SCRIPT_APPROVER = ['aitjcize', 'popodidi', 'JM00oo', 'Spiderpowa'] |
There was a problem hiding this comment.
please remove popodidi ...
aitjcize
reviewed
Oct 3, 2019
scripts/run_bp.py
Outdated
| @@ -155,20 +165,79 @@ def check_environment(): | |||
| 'system time') | |||
|
|
|||
|
|
|||
| def github_get_commits(path): | |||
| return '%s/repos/%s/%s/commits?path=%s&sha=%s' % (_GITHUB_API, _SCRIPT_ORG, _SCRIPT_REPO, path, _SCRIPT_BRANCH) | |||
There was a problem hiding this comment.
please check 80 line alignment for all changes
There was a problem hiding this comment.
also the sha=%s 's argument is _SCRIPT_BRANCH?
There was a problem hiding this comment.
sha parameter takes branch as well.
aitjcize
previously approved these changes
Oct 3, 2019
scripts/run_bp.py
Outdated
|
|
||
|
|
||
| def github_get_approved_commit(commit, approver): | ||
| with urllib.request.urlopen(github_get_commits(_SCRIPT_APPROVE_PATH_TMPL % approver), |
There was a problem hiding this comment.
won't this take a long time?
scripts/run_bp.py
Outdated
| @@ -155,20 +165,79 @@ def check_environment(): | |||
| 'system time') | |||
|
|
|||
|
|
|||
| def github_get_commits(path): | |||
| return '%s/repos/%s/%s/commits?path=%s&sha=%s' % (_GITHUB_API, _SCRIPT_ORG, _SCRIPT_REPO, path, _SCRIPT_BRANCH) | |||
There was a problem hiding this comment.
also the sha=%s 's argument is _SCRIPT_BRANCH?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes:
run_bp.py.sha1file.