【Block上限】修复部分文章无法加载的问题 #1723
Merged
【Block上限】修复部分文章无法加载的问题 #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修复思路是在加载所有文章时，会首先一次性加载数据库中所有block，此时因为上限1000会发生溢出。之后会读取所有page的IDs，然后逐个获取page对应的block。此时如果发现ID查找不到（说明发生了溢出），则再调用API去逐一获取这些溢出了的page。可能这不是最优解。 修改的代码包括： 1. getDataBaseInfoByNotionAPI中添加上述判断逻辑。 2. 修改getPageProperties函数签名，直接传入block对应的value，而不是block数组。
|
请问这个 bug 什么时候可以 fix？ |
修复思路是在加载所有文章时，会首先一次性加载数据库中所有block，此时因为上限1000会发生溢出。之后会读取所有page的IDs，然后逐个获取page对应的block。此时如果发现ID查找不到（说明发生了溢出），则再调用API去逐一获取这些溢出了的page。可能这不是最优解。 修改的代码包括： 1. getDataBaseInfoByNotionAPI中添加上述判断逻辑。 2. 修改getPageProperties函数签名，直接传入block对应的value，而不是block数组。
happyzhangyyds
pushed a commit
to happyzhangyyds/NotionNext
that referenced
this pull request
Apr 30, 2024
修复部分文章无法加载的问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复这个issue中的问题。
fix: 修复部分文章无法加载的问题，原因是Notion API加载时block上限1000
修复思路是在加载所有文章时，会首先一次性加载数据库中所有block，此时因为上限1000会发生溢出。之后会读取所有page的IDs，然后逐个获取page对应的block。此时如果发现ID查找不到（说明发生了溢出），则再调用API去逐一获取这些溢出了的page。可能这不是最优解。
修改的代码包括：