Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

get_device_attribute_list and pipe methods missing from Database interface #313

Closed
lorenzopivetta opened this issue Oct 17, 2019 · 3 comments · Fixed by #317
Closed

get_device_attribute_list and pipe methods missing from Database interface #313

lorenzopivetta opened this issue Oct 17, 2019 · 3 comments · Fixed by #317

Comments

@lorenzopivetta
Copy link

Seems that the method get_device_attribute_list is missing from Database interface (db.py)
@ajoubertza
Copy link
Member

@lorenzopivetta I think it will be easy for me to add it in. Are there any other useful database methods you notice are missing?

Here are the C++ methods: https://github.com/tango-controls/cppTango/blob/tango-9-lts/cppapi/client/Database.h

And the PyTango methods: https://github.com/tango-controls/pytango/blob/develop/tango/db.py

@lorenzopivetta
Copy link
Author

@ajoubertza A quick search shows all the Pipe related methods are missing:
get_device_pipe_list, get_device_pipe_property, put_device_pipe_property, delete_device_pipe_property, get_class_pipe_property, put_class_pipe_property, delete_class_pipe_property, get_class_pipe_list
Not a short list... but would be useful to add.

@grm84
Copy link
Collaborator

grm84 commented Nov 8, 2019

@ajoubertza @lorenzopivetta I'll add all of these to the pybind branch.

ajoubertza added a commit that referenced this issue Nov 17, 2019
@ajoubertza
Fix some database docstrings and formatting
46c67e4 
Some clean up prior to the actual work on issue #313.
ajoubertza added a commit that referenced this issue Nov 17, 2019
@ajoubertza
Add DB get_device_pipe_list and get_class_pipe_list
2e45e61 
This exposes the C++ methods in Python

Issue #313
ajoubertza added a commit that referenced this issue Nov 17, 2019
@ajoubertza
Refactor common DB property attribute and class methods
38bc646 
Before adding similar methods for pipes, the common code is refactored
into generic methods.  The existing generic methods for properties,
e.g., `__Database__generic_get_property` and
`__Database__generic_put_property`, are not quite the same as those
used for the attributes and class methods, so we needed additional
methods.

Issue #313
ajoubertza added a commit that referenced this issue Nov 17, 2019
@ajoubertza
Refactor DB device and class attribute property methods
98ea932 
Before adding similar methods for pipes, the common code is refactored
into generic methods.  The existing generic methods for properties,
e.g., `__Database__generic_get_property` and
`__Database__generic_put_property`, are not quite the same as those
used for the device and class attribute methods, thus the need for
additional methods.

Issue #313
ajoubertza added a commit that referenced this issue Nov 17, 2019
@ajoubertza
Add DB pipe property methods
070ab3a 
Add missing methods for getting, setting and deleting, as well as
history.  Followed the same pattern as the attribute property methods.

Issue #313
@ajoubertza ajoubertza changed the title get_device_attribute_list missing get_device_attribute_list and pipe methods missing from Database interface Nov 17, 2019
@ajoubertza ajoubertza mentioned this issue Nov 17, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add get_device_attribute_list and missing pipe methods to Database interface tango-controls/pytango
3 participants
@grm84 @lorenzopivetta @ajoubertza