This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
Remove explicit metaclass definitions #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 16, 2017 16:13
Closed
|
Looks good, the actual changes to the server stuff are pretty small. I'm going to try it out on my machine. It would be great if @tiagocoutinho could have a look at this too! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
DeviceMetaa subclass ofBoost.Python.class, so the metaclass definition is automatically propagated to the subclasses ofDevice.It also fixes a fundamental issue with asyncio servers that I hadn't noticed until today, see 995db76.
The docs and examples have been simplified (1890f6c and 64c8cc9 promote the
run_servermethod and remove the metaclass definitions).It also fixes issue #74, see 38e1eec (unrelated, but it made my debugging easier).