Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bn3 save editor view #34

Closed
11 tasks done
bigfarts opened this issue Jun 19, 2022 · 7 comments
Closed
11 tasks done

bn3 save editor view #34

bigfarts opened this issue Jun 19, 2022 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bigfarts
Copy link
Contributor

bigfarts commented Jun 19, 2022

things to do:

  • folder support
    • find where the folder info is stored in EWRAM
    • add chip data and icons
    • expose chip info via getFolderEditor
  • navicust support
    • get navicust cata
    • find where navicust data is stored in EWRAM
    • expose navicust info via getNavicustEditor
  • style support
    • find where style data is stored in EWRAM
    • make a UI for this
@bigfarts bigfarts added enhancement New feature or request good first issue Good for newcomers labels Jun 19, 2022
@im-deepfriedwater
Copy link

eager to chip into one of the save editors next month when I get some free time, are there any documentation that might be helpful for getting acquainted with a save format like this? or should I just trial and error and figure out how the other ones are implemented?

@bigfarts
Copy link
Contributor Author

thanks for offering to help! @ssbmars might know more about the bn3 save format itself. for the data, the list of chips in the game's internal indexing is available at https://github.com/murkland/bntools/blob/main/data/3/chips.json

with regards to implementing the save editor, you can implement the FolderEditor interface like so: for things that don't exist like tagchips, you should just be able to return null.

@bigfarts
Copy link
Contributor Author

you shouldn't need to implement the entire bn6 FolderEditor actually, just the parts specified by the interface:

export interface FolderEditor {
getChipData(): (Chip | null)[];
getEquippedFolder(): number;
getChip(
folderIdx: number,
chipIdx: number
): {
id: number;
code: string;
} | null;
isRegularChipInPlace(): boolean;
getRegularChipIndex(folderIdx: number): number | null;
getTagChip1Index(folderIdx: number): number | null;
getTagChip2Index(folderIdx: number): number | null;
}

if you return an instance of your new FolderEditor class from bn3.Editor.getFolderEditor, it should automatically display in the UI as well

@im-deepfriedwater
Copy link

awesome, that's helpful advice for getting started! looking forward to helping out as my schedule frees up!

@bigfarts
Copy link
Contributor Author

if you need any help, feel free to drop by the discord if you haven't already! https://discord.gg/zbQngJHwSg

bigfarts added a commit that referenced this issue Aug 1, 2022
bigfarts added a commit that referenced this issue Aug 2, 2022
@bigfarts
Copy link
Contributor Author

bigfarts commented Aug 2, 2022

sorry, i ended up doing this! thanks for offering to help!

@bigfarts bigfarts closed this as completed Aug 2, 2022
@im-deepfriedwater
Copy link

op good thing I checked my email before I touched this task lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants