Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display bus stops #29

Closed
wants to merge 1 commit into from
Closed

Display bus stops #29

wants to merge 1 commit into from

Conversation

Teester
Copy link

@Teester Teester commented Jun 1, 2017

Fixes #28

This pull request displays bus stops at z18 and their labels at z19. I've set visible: true for both, but you may want to use a global parameter to allow easy switching on and off.

@nvkelso nvkelso mentioned this pull request Jun 9, 2017
@nvkelso
Copy link
Member

nvkelso commented Jun 9, 2017

Closing in favor of #31.

@nvkelso nvkelso closed this Jun 9, 2017
@nvkelso
Copy link
Member

nvkelso commented Jun 9, 2017

The key bug in the stylesheet was needing to include text: { optional: true } to improve collisions (to not require the text display – if the text couldn't display before then the icon would also not show.

I also bumped up the icon size like you suggested, but gradually – and renamed the sublayer later to earlier. That way the visibility all flows instead of needing override the global a couple times.

@nvkelso
Copy link
Member

nvkelso commented Jun 9, 2017

@Teester Thanks for your PR and issue, we appreciate your help to improve the Cinnabar style :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants