-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cinnabar/Zinc plus labels #42
Conversation
- intermittent: [true] | ||
- kind: drain | ||
draw: | ||
lines: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make intermittent water lines dashed to match Bubble Wrap and Refill.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the area filters for |
cinnabar-style.yaml
Outdated
draw: | ||
lines: | ||
#width: [[11, 0.5px], [12, 1.0px], [13, 1.2px], [14, 1.75px], [15, 2.5px], [16, 8m]] | ||
color: [[11, global.green1_r],[12, global.green1_r],[14, global.minor_road3]] | ||
color: [[11, global.green1_r], [12, global.green1_r], [14, global.minor_road3]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only use minor_road3
, see unclassified road on Angle Island near SF which isn't visible.
fill: global.text_fill | ||
size: 12px | ||
stroke: { color: global.text_stroke_road4, width: 4 } | ||
track: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see track labels in the new version, please restore. See Coastal Trail near: 16/37.8333/-122.5379
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index.html
Outdated
var layer = Tangram.leafletLayer({ | ||
// more: 'vector-tiles-M45zxG4' | ||
// default (some): 'vector-tiles-h6AbVZA' | ||
// no: 'vector-tiles-Bp6EQ60' | ||
scene: { import: 'cinnabar-style.yaml', global: { sdk_mapzen_api_key: 'vector-tiles-h6AbVZA' } }, | ||
scene: { import: [tg_baseScene, 'themes/color-cinnabar.yaml'], global: tg_global }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can just say:
scene: { import: [tg_baseScene], global: tg_global },
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check against Refill for our pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…abar-style into sensescape/cinnabar-themes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
more-labels
andno-labels
as official style variants.