Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cinnabar/Zinc plus labels #42

Merged
merged 45 commits into from
Aug 7, 2017
Merged

Cinnabar/Zinc plus labels #42

merged 45 commits into from
Aug 7, 2017

Conversation

sensescape
Copy link
Member

@sensescape sensescape commented Aug 3, 2017

- intermittent: [true]
- kind: drain
draw:
lines:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make intermittent water lines dashed to match Bubble Wrap and Refill.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phoenix area: 16/33.5523/-112.0600

screen shot 2017-08-07 at 11 14 35

@nvkelso
Copy link
Member

nvkelso commented Aug 3, 2017

Can you also update the area filters for water-area-labels: to match Walkabout more (and for the water polygon area filters, too – they are slightly different).

draw:
lines:
#width: [[11, 0.5px], [12, 1.0px], [13, 1.2px], [14, 1.75px], [15, 2.5px], [16, 8m]]
color: [[11, global.green1_r],[12, global.green1_r],[14, global.minor_road3]]
color: [[11, global.green1_r], [12, global.green1_r], [14, global.minor_road3]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only use minor_road3, see unclassified road on Angle Island near SF which isn't visible.

fill: global.text_fill
size: 12px
stroke: { color: global.text_stroke_road4, width: 4 }
track:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see track labels in the new version, please restore. See Coastal Trail near: 16/37.8333/-122.5379

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.html Outdated
var layer = Tangram.leafletLayer({
// more: 'vector-tiles-M45zxG4'
// default (some): 'vector-tiles-h6AbVZA'
// no: 'vector-tiles-Bp6EQ60'
scene: { import: 'cinnabar-style.yaml', global: { sdk_mapzen_api_key: 'vector-tiles-h6AbVZA' } },
scene: { import: [tg_baseScene, 'themes/color-cinnabar.yaml'], global: tg_global },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just say:

            scene: { import: [tg_baseScene], global: tg_global },

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check against Refill for our pattern.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collision is disabled for some city labels Buildings look bad in tilted 3d view Refactor roads layer
2 participants