Omit all tile edges for polylines #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
matteblair
commented
Jan 21, 2016
matteblair
commented
- Fixes polyline builder never checking line segments for coincidence with tile edges (not sure when this was broken)
- Modifies tile edge check to match edges of any tile, not just the current tile
Line segments were not being tested for coincidence with tile edges
Handles cases where geometry is clipped to an N-tile box
|
@tallytalwar give this a quick look if you please. |
|
Sure on it. Thanks |
tallytalwar
added a commit
that referenced
this pull request
Jan 21, 2016
Omit all tile edges for polylines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.