Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for underline text style #723

Closed
nvkelso opened this issue Jun 19, 2019 · 2 comments
Closed

Add support for underline text style #723

nvkelso opened this issue Jun 19, 2019 · 2 comments
Milestone
v0.21.0

Comments

@nvkelso
Copy link
Member

nvkelso commented Jun 19, 2019 •
edited

I'd like to add underline text treatment to callout country and regional capitals in map styles. We adding better support for both in the new v1.8 Tilezen schema, but right now the only way to call them out visually is to change the color. One common technique in cartography is to underline capital text.

There are two options for the underline – if there is letter spacing (or spaces) the underline should optionally continue as one "line"... but the default is usually to only do it under word blocks. The weight of the line (thickness or stroke) should match the weight of the text.
@nvkelso nvkelso mentioned this issue Jun 19, 2019
Closed
@nvkelso
Copy link
Member Author

nvkelso commented Jun 19, 2019

Similar text highlight boxes: #724

@bcamper bcamper mentioned this issue Jul 11, 2020
Merged
@bcamper bcamper added this to the v0.21.0 milestone Aug 2, 2020
@bcamper
Copy link
Member

bcamper commented Aug 2, 2020

released in v0.21.0

@bcamper bcamper closed this as completed Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21.0
Development

No branches or pull requests
2 participants
@bcamper @nvkelso