bug: Lockscreen info not displayed anymore

[dylancom]

Since I recently upgraded to the latest pod of this project, the lock screen doesn't show info anymore (artist, title & artwork).
I also tested the Example project to make sure it's not related to my code and also there I don't see any lock screen info.

I found that self.mediaInfo is nil at: https://github.com/tanhakabir/SwiftAudioPlayer/blob/master/Source/SAPlayerPresenter.swift#L123

[tanhakabir]

Will look into today!

[dylancom]

@tanhakabir I found that I was using 3.0.0 before and if I switch back to 3.0.0 the lockscreen is working fine again.

The lockscreen info missing seems to be introduced as of 4.0.0

[tanhakabir]

Thanks for testing that for me! I'm having a couple issues with my Apple Dev account right now so I can't test on device but just to confirm you are sending lockscreen info on start correct? I see that the latest example app wasn't

[tanhakabir]

pushed a fix to the example app to pass in the lockscreen info

[dylancom]

@tanhakabir no thanks, I was hoping I could push a PR myself but haven't found the fix yet.
Yes I'm using SAPlayer.shared.startSavedAudio(withSavedUrl: url, mediaInfo: info) from the start.
What I found is that handleLockscreenInfo(info) get's called with the correct info, but inside attachForUpdates() self.mediaInfo seems to remain nil.

The updated example still doesn't seem to show the provided mediaInfo.

[tanhakabir]

Hmm I'm not reproing that at the moment but once I can fix my dev account I can check on my device to confirm

[dezinezync]

I am also able to reliably reproduce @dylancom's issue against the master branch.

[dezinezync]

I've traced it down to func handlePlayStreamedAudio(withRemoteUrl url: URL, bitrate: SAPlayerBitrate) inside SAPlayerPresenter line 94.

It calls handleClear() which removes the media info from the presenter.

Update: disabling the handleClear from there, and manually calling clear on the player before starting the next playback resolves the issue. So handleClear needs to be updated to manage existing valid mediaInfo instead of setting it to nil.

[dylancom]

@dezinezync good catch. So it seems to be introduced by this commit: 542f65f
(The start of adding queuing functionality)

[dezinezync]

Can confirm, this fixes the issue.