added close browser method

[homanchou]

firefox was left open on subsequent tests, added method to close watir browser

[tanin47]

I leave it open so that user can observe javascript errors through Firebug, otherwise we have no way to do that.

What do you think?

[homanchou]

Oh I see. Then perhaps you can allow these browser open and close options
to be user customized in the spec_helper as part of the setup, similar to
how database_cleaner gem does it: https://github.com/bmabey/database_cleaner

Or, another idea is to make closing of the browser the default (Because many
times as I develop I run the test over and over again and I will sometimes
get an error if I forget to close the previous browser, or it's just a
surprise to see a collection of firefox icons building up in my task bar.),
but keep the browser open on a per test basis as needed by adding something
like 'save_and_open_page' similar to capybara works with launchy gem. In
which case the browser should stay open at that point and any subsequent
tests in the test suite should use a different browser instance instead
otherwise the same browser will be driven to a different page, yes?

Homan

On Fri, Oct 28, 2011 at 3:42 AM, Tanin Na Nakorn <
reply@reply.github.com>wrote:

I leave it open for future debugging through Firefox, otherwise we have no
way to observe javascript errors.

What do you think?

Reply to this email directly or view it on GitHub:

#2 (comment)

[tanin47]

I agree with you. Right now I'm extremely busy with my new website, gamling.org (relieving flooding in Thailand).

I will probably make the change soon, or you could do another pull request. Either way is fine.