Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawing: Atrial Flutter Ratio Rendering Incorrectly #139

Closed
tanjera opened this issue Oct 16, 2021 · 4 comments
Closed

Drawing: Atrial Flutter Ratio Rendering Incorrectly #139

tanjera opened this issue Oct 16, 2021 · 4 comments
Assignees
@tanjera
Labels
bug
Milestone
Version 2.1

Comments

@tanjera
Copy link
Owner

tanjera commented Oct 16, 2021 •
edited

Reproducible with atrial flutter @ 80bpm
@tanjera tanjera added the bug label Oct 16, 2021
@tanjera tanjera added this to the Version 2.1 milestone Oct 16, 2021
@tanjera tanjera self-assigned this Oct 16, 2021
@tanjera tanjera changed the title Drawing: Atrial Fibrillation Ratio Rendering Incorrectly Drawing: Atrial Flutter Ratio Rendering Incorrectly Oct 16, 2021
@tanjera
Copy link
Owner Author

tanjera commented Jul 15, 2022

afib screencap 120

afib screencap 40

afib screencap 80

@tanjera
Copy link
Owner Author

tanjera commented Jul 15, 2022 •
edited

Multiple problems noted:

  • Number of flutters unrealistic along HR spectrum (7 flutters @ 40bpm, 1.5?! flutters at 120bpm)
  • Incomplete flutters: this could be slightly realistic with slight AV conduction delay, but see phase problem below.
  • Flutters and QRS complexes out of phase synchronicity: this would model an unrealistic wandering AV conduction delay (seen as varying PQ intervals each beat)

Modeling targets:

  • 3 to 5 flutters per beat, with 4 flutters @ 60bpm. Okay if P waves propagate faster/shorter with tachycardia.
  • Phase synchronicity: no wandering AV conduction (PQ intervals consistent!)

@tanjera
Copy link
Owner Author

tanjera commented Jul 15, 2022

Attempt #1: Modeled flutters and QRS complexes in single draw call
Result:

  • Completely fixed all the problems in this issue
  • Completely broke synchronicity with Patient modeling: ventricular waveforms didn't line up with pulsatile waveforms (ABP)

Not acceptable. Will try something else...

tanjera added a commit that referenced this issue Jul 15, 2022
@tanjera
IISIM 2.2.0: Release, p QoL and Debugging; IIDT 1.0.5
452cfb9 
IISIM: Quality of Life improvements
- Audio now enabled by default (previously bool initialized to false)
- Audio alarms do not trigger if Instance.Settings.AudioEnabled == false
- On Device.SetAlarms(false/disabled), alarms actively disabled/silenced
- DialogMessage implemented (from IISE, to IISIM standards) (*)
- DialogAudioUnavailable() notifies user if LibVLC load failed (*)
  - Uses end-user language, instructs to follow installation instructions
- * All strings localized and dictionary updated
Debugging
- Cross-platform pre-release testing of new features and libraries
- Closed & Disposed of MemoryStreams at DeviceMonitor OnClosing
- AudioLib new() in try/catch, downstream null checking implemented
  - Allows for running IISIM without LibVLC (no audio will play)
- Protected from accidentally Disposing MediaPlayer multiple times
  - Caused a Memory Exception d/t wrapping C++ unmanaged code
- Moved DisposeAudio() to ensure alarms stop when DeviceMonitor is closed!
  - Was playing in background of closed Window!
- Reworked draw calls and modeling for Issue #139 (re: a-flutter)
  - Adjusted ECG_Isoelectric__Atrial_Flutter() to dynamic flutter lengths
    - Brought waveform drawing into phase synchronicity
    - Clamped flutters to between 3-5 per beat
  - Implemented OnPatientEvent (Cardiac_Baseline) in OnPacemaker_Spike()
    - Allows isoelectric lines to be drawn
      - Retains a-fib/flutter P wave activity between paced beats
    - All cardiac rhythms re-tested with pacemaker for clinical modeling realism
- Fixed "Reset Parameters" functionality (Issue #143)
  - Was resetting Patient... that was incorrect behavior
  - Now just resets view to Patient parameters (resets pending changes)
  - [Un]checking "Auto Apply Changes" now disables "Reset Parameters" button
    - Because if parameters are auto-applying, can't reset (undo)!
IIDT 1.0.5:
- Publishing Utility
  - Now packs .zip files properly (as pkzip, using 7zip)
    - Windows previously unable to read .tar named as .zip
      - WinRAR and7Zip were fine
  - Now names tarballs .tar and zip files .zip properly
  - Tar files now using gzip compression (d/t/ increased file sizes w/ LibVLC)
- Linux and OSX scripts updated file name input (.tar.gz) and gzip compression
- .deb package dependencies added and tested for LibVLC (vlc, libvlc-dev)
@tanjera
Copy link
Owner Author

tanjera commented Jul 15, 2022

Fixed in 1ec5cfd

@tanjera tanjera closed this as completed Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanjera tanjera

Labels
bug
Projects
None yet
Milestone
Version 2.1
Development

No branches or pull requests
1 participant
@tanjera