Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl support #40

Merged
merged 2 commits into from
Aug 4, 2019
Merged

ssl support #40

merged 2 commits into from
Aug 4, 2019

Conversation

tank-bohr
Copy link
Owner

Changes:

  • Introduce ssl support for https
  • For more detailed request inspection
  • Some breaking changes: Use propplist for options instead of single integer for port

Rationale:

@codecov
Copy link

codecov bot commented Aug 4, 2019

Codecov Report

Merging #40 into master will decrease coverage by 0.33%.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   96.39%   96.06%   -0.34%     
==========================================
  Files           5        6       +1     
  Lines         111      127      +16     
==========================================
+ Hits          107      122      +15     
- Misses          4        5       +1
Impacted Files Coverage Δ
src/bookish_spork.erl 100% <100%> (ø) ⬆️
src/bookish_spork_server.erl 93.65% <100%> (+0.54%) ⬆️
src/bookish_spork_request.erl 100% <100%> (ø) ⬆️
src/bookish_spork_ssl.erl 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc2434...658f8b0. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 4, 2019

Codecov Report

Merging #40 into master will decrease coverage by 0.24%.
The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   96.39%   96.15%   -0.25%     
==========================================
  Files           5        6       +1     
  Lines         111      130      +19     
==========================================
+ Hits          107      125      +18     
- Misses          4        5       +1
Impacted Files Coverage Δ
src/bookish_spork.erl 100% <100%> (ø) ⬆️
src/bookish_spork_server.erl 93.65% <100%> (+0.54%) ⬆️
src/bookish_spork_request.erl 100% <100%> (ø) ⬆️
src/bookish_spork_ssl.erl 90% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc2434...9329534. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant