Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add clear to QueryResultBase #696

Merged
merged 1 commit into from Jul 2, 2020
Merged

fix(types): add clear to QueryResultBase #696

merged 1 commit into from Jul 2, 2020

Conversation

MarceloAlves
Copy link
Contributor

Adds type for clear() on QueryResultBase

closes #692

@MichaelDeBoey MichaelDeBoey merged commit 9a68fed into TanStack:master Jul 2, 2020
@MichaelDeBoey
Copy link
Collaborator

@all-contributors Please add @MarceloAlves for code

@allcontributors allcontributors bot mentioned this pull request Jul 2, 2020
Merged
@allcontributors
Copy link
Contributor

@MichaelDeBoey

I've put up a pull request to add @MarceloAlves! 🎉

@MichaelDeBoey
Copy link
Collaborator

This should be added to the docs too

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 2.4.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MarceloAlves MarceloAlves deleted the marceloalves/add-clear-type branch July 2, 2020 23:50
@MarceloAlves
Copy link
Contributor Author

@MichaelDeBoey Ah yes! Will open another PR for that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clear is missing in QueryResult type definition
3 participants
@MarceloAlves @MichaelDeBoey @tannerlinsley