Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow abstract constructor signatures for hasMixin #57

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Allow abstract constructor signatures for hasMixin #57

merged 3 commits into from
Feb 8, 2023

Conversation

tinkerborg
Copy link

@tinkerborg tinkerborg commented Feb 8, 2023 •
edited
Loading

  • fix: allow abstract constructor signature for hasMixin

@tinkerborg tinkerborg force-pushed the fix/hasMixin branch 2 times, most recently from e69a697 to 527f898 Compare February 8, 2023 16:03
tannerntannern
tannerntannern requested changes Feb 8, 2023
View reviewed changes
Copy link
Owner

@tannerntannern tannerntannern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @tinkerborg! One small suggestion, then I'll accept the PR

src/mixin-tracking.ts Outdated Show resolved Hide resolved
@tannerntannern
Copy link
Owner

Fixes #56

@tinkerborg
Copy link
Author

@tannerntannern Fixed the constructor signature and also added a unit test.

tannerntannern
tannerntannern approved these changes Feb 8, 2023
View reviewed changes
Copy link
Owner

@tannerntannern tannerntannern left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thanks for the quick fix and the added unit test! I will get this released to npm after work.

@tannerntannern tannerntannern merged commit 8964b59 into tannerntannern:master Feb 8, 2023
@tannerntannern
Copy link
Owner

These changes were released in v6.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannerntannern tannerntannern tannerntannern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tinkerborg @tannerntannern