Added Merge, MarshalBinary, UnmarshalBinary #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the initial tests failed because of:
So I'll disable that |
jameshartig
force-pushed
the
master
branch
3 times, most recently
from
db42505
to
9b9841a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 138 171 +33
=====================================
+ Hits 138 171 +33
Continue to review full report at Codecov.
|
jameshartig
force-pushed
the
master
branch
2 times, most recently
from
500adaf
to
740c165
Compare
tannerryan
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to merge multiple different Ring's from different hours of data since we process our data in hourly chunks concurrently. The Marshal/Unmarshal methods will be necessary so we can store already-processed hours in a database so we don't need to re-compute them all of the time.
I added tests to test the Merge and Marshal methods but I made them separate tests. They're still ran by
TestMainbut they don't affect the stats output./cc @TheTannerRyan