-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more ftdi wrappers #2
Conversation
Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
Hello @geomatsi, Thank you for contributing. Your wrappers look ok if we're wrapping the API at this level. However, I'd probably prefer to look into rewriting this API into a more Rust-like one, or at least checking whether the I'll try to refresh this area and review the API additions more thoroughly in a few days. |
Hi @tanriol , Regards, |
Hi @tanriol , Friendly ping. Any updates from your side ? Regards, |
Do you have any specific reason to need |
Well, I don't have any specific reason other than proper shutdown of USB connection after purging all the buffers. Consider the case when you run multiple tests, creating and destroying FTDI context. So I would like to clean up previous test state before running the next one. Technically I used |
I'd expect |
Ok. I am going to close this PR since there is a larger rework is ongoing. BTW, did you think about the following possibility: make one more release with older API and minor updates (v0.0.3) and bump release for the new API (e.g. v0.1.0) ? |
As far as I remember, for Cargo |
@geomatsi I wasn't aware this PR was closed. My open PRs #7, #8, and #9 were meant to directly incorporate this PR, PR #1, and Do you have plans to try the new version when it's released? |
Hi @cr1901 After brief discussion with @tanriol , I've got an impression that you are working on a larger rework: see our discussion above. So I closed my PR assuming it won't be needed. I plan to adapt my ftdi-embedded-hal to new ftdi-rs API later on. So let me know if you still need this closed PR. I will re-open if needed. Regards, |
This PR adds the following new Rust wrappers for libftdi functions:
Besides, minor cleanup patch is queued: coding style by rust fmt.
Regards,
Sergey