Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast-async babel plugin modifies Function.prototype globally #46

Closed
fmnxl opened this issue Nov 19, 2019 · 4 comments · Fixed by #52
Closed

fast-async babel plugin modifies Function.prototype globally #46

fmnxl opened this issue Nov 19, 2019 · 4 comments · Fixed by #52

Comments

@fmnxl
Copy link
Contributor

fmnxl commented Nov 19, 2019

I wonder if we can let the user decide to use fast-async themselves, rather than being baked in this project.

One reason could be that it can impact other parts of their app (see my PR to react-native facebook/react-native#27264).

It currently breaks react native apps that does dynamic styling through passing a function to StyleSheet.create

@fmnxl fmnxl changed the title fast-async babel plugin modified Function.prototype globally fast-async babel plugin modifies Function.prototype globally Nov 19, 2019
@tannerlinsley
Copy link
Collaborator

I would be okay moving back to the generator transformer. As long as someone PRs something to the docs on how to properly use fast-async

@tannerlinsley
Copy link
Collaborator

Would you be willing to do that?

@fmnxl
Copy link
Contributor Author

fmnxl commented Nov 20, 2019

Yes! I'll submit a PR :)

@fmnxl
Copy link
Contributor Author

fmnxl commented Nov 25, 2019

I think I've found another solution: exclude nodent runtime.

#52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants