Skip to content

Remove fast async nodent runtime#52

Merged
tannerlinsley merged 1 commit intoTanStack:masterfrom
fmnxl:remove-fast-async-nodent-runtime
Nov 25, 2019
Merged

Remove fast async nodent runtime#52
tannerlinsley merged 1 commit intoTanStack:masterfrom
fmnxl:remove-fast-async-nodent-runtime

Conversation

@fmnxl
Copy link
Copy Markdown
Contributor

@fmnxl fmnxl commented Nov 25, 2019

fast-async injects the nodent runtime, which adds Function.prototype.$asyncbind to the output.

This runtime method is not used in the output, so we can remove it.

Resolves #46

Comment thread package.json
"eslint-plugin-react": "7.x",
"eslint-plugin-react-hooks": "1.5.0",
"eslint-plugin-standard": "^4.0.0",
"fast-async": "^6.3.8",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was missing for me

@tannerlinsley
Copy link
Copy Markdown
Member

Incredible! Great work!

@tannerlinsley tannerlinsley merged commit 61d6eb1 into TanStack:master Nov 25, 2019
@tannerlinsley
Copy link
Copy Markdown
Member

Screen Shot 2019-11-25 at 9 28 48 AM

@fmnxl
Copy link
Copy Markdown
Contributor Author

fmnxl commented Nov 25, 2019

Awesome! Thanks for merging this so quickly :))

@tannerlinsley
Copy link
Copy Markdown
Member

Of course!

@fmnxl fmnxl deleted the remove-fast-async-nodent-runtime branch November 25, 2019 16:48
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Dec 7, 2024

View your CI Pipeline Execution ↗ for commit e5bd674

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-20 17:21:56 UTC

GEREGUR pushed a commit to GEREGUR/query that referenced this pull request Feb 17, 2026
Don't play timer spinning animation for reduced motion users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fast-async babel plugin modifies Function.prototype globally

2 participants