Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json specified module incorrectly in react-location-devtools #105

Closed
chungweileong94 opened this issue Nov 21, 2021 · 4 comments
Closed

Comments

@chungweileong94
Copy link
Contributor

Describe the bug
So I use Vite for my React project, and it failed the dev build and manage to find that the module is specified incorrectly in the package.json, or I should say the es module file doesn't seem to get bundled. I can definitely make it works by removing the module field as a workaround

To Reproduce
Steps to reproduce the behavior:

  1. Create a React project via ViteJS
  2. Setup react-location & react-location-devtools
  3. Start the dev server

Expected behavior
The dev server should run just normal.

Screenshots
Screenshot 2021-11-21 at 10 04 52 PM

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Edge
  • Version: 95.0.1020.53

Smartphone (please complete the following information):

  • Device: -
  • OS: -
  • Browser: -
  • Version:-

Additional context
None

@tannerlinsley
Copy link
Collaborator

I just shipped an attempted fix that implements the imports exactly how React Query does. Hopefully it works for you :) If not, reopen/comment here.

@chungweileong94
Copy link
Contributor Author

@tannerlinsley Thanks for the update.

However, it doesn't seem like the issue is fixed, in fact now both the main & module is pointing to nothing. Am I missing anything?
Screenshot 2021-11-23 at 8 55 07 PM
ed

@tannerlinsley
Copy link
Collaborator

Try again in 10 minutes

@chungweileong94
Copy link
Contributor Author

Try again in 10 minutes

Cool, it works perfectly now!
Thanks for the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants