Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotation values too far away from slide #30

Closed
jancborchardt opened this issue Jun 28, 2012 · 7 comments
Closed

rotation values too far away from slide #30

jancborchardt opened this issue Jun 28, 2012 · 7 comments

Comments

@jancborchardt
Copy link
Contributor

It is very unclear that the Rot X, Y and Z values concern the slide that is currently selected, because they are in a toolbar that is way too far from the element it modifies.

Instead, the 3 values should be in proximity of the current slide. Much like the depth and scale elements they should only appear when needed, when the slide is clicked.

@ghost ghost assigned tantaman Jun 28, 2012
@tantaman
Copy link
Owner

Someone has actually already made this change in a fork so I should be able to merge it tonight.

tantaman added a commit that referenced this issue Jun 29, 2012
-Added x,y manual field entry for slide components
-Moved Rotate x,y,z manual field entries
-Changed z and scale field entries from crappy spinners
@tantaman
Copy link
Owner

The slides, on the transition editor, look a little bit cluttered now.. What do you think?

We probably want to round the rotation values to the first decimal place and normalize the rotations to be between 0 and 2*PI as well.

@jancborchardt
Copy link
Contributor Author

Yeah, essentially it’s only 5 functions, but due to the text and distinction of label from input it looks like way more.

I’ll experiment with the design a bit there, will be back (note to self: use ↻ instead of »Rot.«, rename »z« to something like »layer« or similar).
Regarding scale and depth/layer control – I think this is in another issue already, but the scale should reflect in the actual size of the slide. And the layer should probably be visualized through brightness or opacity (the higher the slide, the brighter and vice versa). Oh also, layer and scale should be possible to change by dragging on the label, much like the rotation values. What do you think?

(I totally agree the rotation values should be rounded, even to have no decimal places at all. Input with decimals should be possible, but it should just omit them when displaying because yeah, that’s pretty unnecessarily detailed.)

@jancborchardt
Copy link
Contributor Author

Same in the slide editor – for easier perception and also to make the controls a bit smaller, the text should be changed to icons.

skew x, skew y and scale should just be a ↔ (the 90° and 45° rotation will explain enough)
for positioning, X should be → and Y should be ↑ (X and Y are mathematical terms which you always need to convert to directions in your head)
rotate should be ↻

What do you think?

@jancborchardt
Copy link
Contributor Author

Just as info: I work on making the controls icons only, be visible enough and also be not that obtrusive. (But I’m at IndieWebCamp currently so I’ll push it later :)

@ghost ghost assigned jancborchardt Jul 1, 2012
@tantaman
Copy link
Owner

tantaman commented Jul 3, 2012

The 2013 indie web camp is a month long? "The third annual IndieWebCamp will be June 22 through July 23, 2013"
I hope that is a typo lol

@jancborchardt
Copy link
Contributor Author

I improved the controls a bit and pushed to master. Going forward I want to clean it up more and visually connect the labels better with their input fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants