Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition between filtering and refreshing apps #417 #458

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

paperclipstudio
Copy link
Contributor

Added updating filter on appList observer.
To test the change I added the following at line 79

   else if (query?.contains("o") == true) {
                    // Force an update to the appList
                    viewModel.appList.value = viewModel.appList.value
                }

Then I would enter into the search bar pho - Which should show the two options photo and phone

Then on submit we then get a forced update to appList (and skips opening an app)

  • Without this PR -> The list gets filled with all the apps.
  • With this PR -> The list stays with just the two options

I haven't worked on android before so I hope this is good.

@paperclipstudio paperclipstudio marked this pull request as draft February 23, 2024 00:08
@paperclipstudio
Copy link
Contributor Author

The second change is just a small fix for the undocumented web search feature I came across. basicly it fixes the "!" prefix being kept and using the the new websearch.

@paperclipstudio paperclipstudio marked this pull request as ready for review February 23, 2024 00:29
Copy link
Owner

@tanujnotes tanujnotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bang search doesn't work without !
https://duckduckgo.com/bangs

@paperclipstudio
Copy link
Contributor Author

Sure, I'll remove that commit.
but wouldn't it be better to use ! for general websearch? and have !! (the same code) for band search?

@paperclipstudio
Copy link
Contributor Author

should be good now.

@tanujnotes tanujnotes merged commit 569f342 into tanujnotes:master Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants