Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating dialogs get stuck #100

Closed
Chaitanyabsprip opened this issue Aug 23, 2021 · 0 comments · Fixed by #152
Closed

Floating dialogs get stuck #100

Chaitanyabsprip opened this issue Aug 23, 2021 · 0 comments · Fixed by #152
Labels
bug Something isn't working
Milestone

Comments

@Chaitanyabsprip
Copy link

Description

When I install the plugin and call lua vim.lsp.buf.hover() the hover dialog gets stuck. Without the plugin installed the hover windows work absolutely fine.

  • nvim --version output:
  • NVIM v0.5.0
Build type: Release
LuaJIT 2.1.0-beta3
Compilation: clang -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_TS_HAS_SET_MATCH_LIMIT -O2 -DNDEBUG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/tmp/neovim-20210702-97973-1wtbty6/neovim-0.5.0/build/config -I/tmp/neovim-20210702-97973-1wtbty6/neovim-0.5.0/src -I/opt/homebrew/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/opt/homebrew/opt/gettext/include -I/tmp/neovim-20210702-97973-1wtbty6/neovim-0.5.0/build/src/nvim/auto -I/tmp/neovim-20210702-97973-1wtbty6/neovim-0.5.0/build/include
Compiled by brew@HMBRW-A-001-M1-005.local

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/opt/homebrew/Cellar/neovim/0.5.0/share/nvim"

Run :checkhealth for more info
  • Operating system: MacOS Big Sur 11.5.2
@Chaitanyabsprip Chaitanyabsprip added the bug Something isn't working label Aug 23, 2021
@tanvirtin tanvirtin added this to the v0.1.0 milestone Nov 17, 2021
tanvirtin added a commit that referenced this issue Dec 26, 2021
New Features:
- Much better user interface
- Much more performant
- Users can now cycle through the table view
- Reduced bloat from project
- Split diff view in hunk preview
- Ability for users to perform existing commands across Project Diff Preview.
- VGit now recognizes git files outside of the project's working directory
- VGit will now recognize if a file has been renamed.
- New preview called `project_hunks_preview` to open a quick preview of all the hunks in your entire project which looks similar to the quickfix preview, but with the VGit `CodeComponent` baked inside it. Allowing you to quickly see all the diffs in your project in both split and unified diff views.
- Ton of quality life improvements

Removed Features:
- diff base for gutter (current implementation makes the system very convoluted to use, e.g VSCode doesn't even support this)
- telescope integration (unnecessary bloat)
- Removed theming support (useless features makes makes codebase messy and complex)
- Removed layout support (too much configuration makes code harder to maintain)
- Renamed `buffer_staged_diff_preview` to `buffer_diff_staged_preview`

Closes issues:
- #120
- #119
- #100
- #79
- #145
- #155
- #154
tanvirtin added a commit that referenced this issue Dec 26, 2021
New Features:
- Much better user interface
- Much more performant
- Users can now cycle through the table view
- Reduced bloat from project
- Split diff view in hunk preview
- Ability for users to perform existing commands across Project Diff Preview.
- VGit now recognizes git files outside of the project's working directory
- VGit will now recognize if a file has been renamed.
- New preview called `project_hunks_preview` to open a quick preview of all the hunks in your entire project which looks similar to the quickfix preview, but with the VGit `CodeComponent` baked inside it. Allowing you to quickly see all the diffs in your project in both split and unified diff views.
- Ton of quality life improvements

Removed Features:
- diff base for gutter (current implementation makes the system very convoluted to use, e.g VSCode doesn't even support this)
- telescope integration (unnecessary bloat)
- Removed theming support (useless features makes makes codebase messy and complex)
- Removed layout support (too much configuration makes code harder to maintain)
- Renamed `buffer_staged_diff_preview` to `buffer_diff_staged_preview`

Closes issues:
- #120
- #119
- #100
- #79
- #145
- #155
- #154
tanvirtin added a commit that referenced this issue Dec 26, 2021
New Features:
- Much better user interface
- Much more performant
- Users can now cycle through the table view
- Reduced bloat from project
- Split diff view in hunk preview
- Ability for users to perform existing commands across Project Diff Preview.
- VGit now recognizes git files outside of the project's working directory
- VGit will now recognize if a file has been renamed.
- New preview called `project_hunks_preview` to open a quick preview of all the hunks in your entire project which looks similar to the quickfix preview, but with the VGit `CodeComponent` baked inside it. Allowing you to quickly see all the diffs in your project in both split and unified diff views.
- Ton of quality life improvements

Removed Features:
- diff base for gutter (current implementation makes the system very convoluted to use, e.g VSCode doesn't even support this)
- telescope integration (unnecessary bloat)
- Removed theming support (useless features makes makes codebase messy and complex)
- Removed layout support (too much configuration makes code harder to maintain)
- Renamed `buffer_staged_diff_preview` to `buffer_diff_staged_preview`

Closes issues:
- #120
- #119
- #100
- #79
- #145
- #155
- #154
- #135
tanvirtin added a commit that referenced this issue Dec 27, 2021
New Features:
- Much better user interface
- Much more performant
- Users can now cycle through the table view
- Reduced bloat from project
- Split diff view in hunk preview
- Ability for users to perform existing commands across Project Diff Preview.
- VGit now recognizes git files outside of the project's working directory
- VGit will now recognize if a file has been renamed.
- New preview called `project_hunks_preview` to open a quick preview of all the hunks in your entire project which looks similar to the quickfix preview, but with the VGit `CodeComponent` baked inside it. Allowing you to quickly see all the diffs in your project in both split and unified diff views.
- Ton of quality life improvements
- Optimized diff rendering

Removed Features:
- diff base for gutter (current implementation makes the system very convoluted to use, e.g VSCode doesn't even support this)
- telescope integration (unnecessary bloat)
- Removed theming support (useless features makes makes codebase messy and complex)
- Removed layout support (too much configuration makes code harder to maintain)
- Renamed `buffer_staged_diff_preview` to `buffer_diff_staged_preview`

Closes issues:
- #120
- #119
- #100
- #79
- #145
- #155
- #154
- #135
tanvirtin added a commit that referenced this issue Dec 28, 2021
New Features:
- Much better user interface
- Much more performant
- Users can now cycle through the table view
- Reduced bloat from project
- Split diff view in hunk preview
- Ability for users to perform existing commands across Project Diff Preview.
- VGit now recognizes git files outside of the project's working directory
- VGit will now recognize if a file has been renamed.
- New preview called `project_hunks_preview` to open a quick preview of all the hunks in your entire project which looks similar to the quickfix preview, but with the VGit `CodeComponent` baked inside it. Allowing you to quickly see all the diffs in your project in both split and unified diff views.
- Ton of quality life improvements
- Optimized diff rendering

Removed Features:
- diff base for gutter (current implementation makes the system very convoluted to use, e.g VSCode doesn't even support this)
- telescope integration (unnecessary bloat)
- Removed theming support (useless features makes makes codebase messy and complex)
- Removed layout support (too much configuration makes code harder to maintain)
- Renamed `buffer_staged_diff_preview` to `buffer_diff_staged_preview`

Closes issues:
- #120
- #119
- #100
- #79
- #145
- #155
- #154
- #135
tanvirtin added a commit that referenced this issue Dec 28, 2021
New Features:
- Much better user interface
- Much more performant
- Users can now cycle through the table view
- Reduced bloat from project
- Split diff view in hunk preview
- Ability for users to perform existing commands across Project Diff Preview.
- VGit now recognizes git files outside of the project's working directory
- VGit will now recognize if a file has been renamed.
- New preview called `project_hunks_preview` to open a quick preview of all the hunks in your entire project which looks similar to the quickfix preview, but with the VGit `CodeComponent` baked inside it. Allowing you to quickly see all the diffs in your project in both split and unified diff views.
- Ton of quality life improvements
- Optimized diff rendering

Removed Features:
- diff base for gutter (current implementation makes the system very convoluted to use, e.g VSCode doesn't even support this)
- telescope integration (unnecessary bloat)
- Removed theming support (useless features makes makes codebase messy and complex)
- Removed layout support (too much configuration makes code harder to maintain)
- Renamed `buffer_staged_diff_preview` to `buffer_diff_staged_preview`

Closes issues:
- #120
- #119
- #100
- #79
- #145
- #155
- #154
- #135
tanvirtin added a commit that referenced this issue Dec 28, 2021
New Features:
- Much better user interface
- Much more performant
- Users can now cycle through the table view
- Reduced bloat from project
- Split diff view in hunk preview
- Ability for users to perform existing commands across Project Diff Preview.
- VGit now recognizes git files outside of the project's working directory
- VGit will now recognize if a file has been renamed.
- New preview called `project_hunks_preview` to open a quick preview of all the hunks in your entire project which looks similar to the quickfix preview, but with the VGit `CodeComponent` baked inside it. Allowing you to quickly see all the diffs in your project in both split and unified diff views.
- Ton of quality life improvements
- Optimized diff rendering

Removed Features:
- diff base for gutter (current implementation makes the system very convoluted to use, e.g VSCode doesn't even support this)
- telescope integration (unnecessary bloat)
- Removed theming support (useless features makes makes codebase messy and complex)
- Removed layout support (too much configuration makes code harder to maintain)
- Renamed `buffer_staged_diff_preview` to `buffer_diff_staged_preview`

Closes issues:
- #120
- #119
- #100
- #79
- #145
- #155
- #154
- #135
@tanvirtin tanvirtin linked a pull request Dec 28, 2021 that will close this issue
tanvirtin added a commit that referenced this issue Dec 28, 2021
New Features:
- Much better user interface
- Much more performant
- Users can now cycle through the table view
- Reduced bloat from project
- Split diff view in hunk preview
- Ability for users to perform existing commands across Project Diff Preview.
- VGit now recognizes git files outside of the project's working directory
- VGit will now recognize if a file has been renamed.
- New preview called `project_hunks_preview` to open a quick preview of all the hunks in your entire project which looks similar to the quickfix preview, but with the VGit `CodeComponent` baked inside it. Allowing you to quickly see all the diffs in your project in both split and unified diff views.
- Ton of quality life improvements
- Optimized diff rendering

Removed Features:
- diff base for gutter (current implementation makes the system very convoluted to use, e.g VSCode doesn't even support this)
- telescope integration (unnecessary bloat)
- Removed theming support (useless features makes makes codebase messy and complex)
- Removed layout support (too much configuration makes code harder to maintain)
- Renamed `buffer_staged_diff_preview` to `buffer_diff_staged_preview`

Closes issues:
- #120
- #119
- #100
- #79
- #145
- #155
- #154
- #135
tanvirtin added a commit that referenced this issue Dec 28, 2021
New Features:
- Much better user interface
- Much more performant
- Users can now cycle through the table view
- Reduced bloat from project
- Split diff view in hunk preview
- Ability for users to perform existing commands across Project Diff Preview.
- VGit now recognizes git files outside of the project's working directory
- VGit will now recognize if a file has been renamed.
- New preview called `project_hunks_preview` to open a quick preview of all the hunks in your entire project which looks similar to the quickfix preview, but with the VGit `CodeComponent` baked inside it. Allowing you to quickly see all the diffs in your project in both split and unified diff views.
- Ton of quality life improvements
- Optimized diff rendering

Removed Features:
- diff base for gutter (current implementation makes the system very convoluted to use, e.g VSCode doesn't even support this)
- telescope integration (unnecessary bloat)
- Removed theming support (useless features makes makes codebase messy and complex)
- Removed layout support (too much configuration makes code harder to maintain)
- Renamed `buffer_staged_diff_preview` to `buffer_diff_staged_preview`

Closes issues:
- #120
- #119
- #100
- #79
- #145
- #155
- #154
- #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants