Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added buffer var with current diff stats (#157, #212) #220

Merged
merged 1 commit into from
May 3, 2022
Merged

feat: added buffer var with current diff stats (#157, #212) #220

merged 1 commit into from
May 3, 2022

Conversation

ibhagwan
Copy link
Contributor

@ibhagwan ibhagwan commented May 3, 2022

As requested in #218, separate PR to fix #157, #212 rebased for the latest changes.

I did note a bug that didn't exist before e5ba324, when opening a non-tracked file hunk.stat shows all lines of the current buffer as added, this happens on files even outside of the current repo path.

@ibhagwan
Copy link
Contributor Author

ibhagwan commented May 3, 2022

Forced pushed based on our discussion in #219, I think you'd like this one better :-)

Copy link
Owner

@tanvirtin tanvirtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the nitpicks with the comments, but it's looking good in terms of functionality. Thanks again for taking the time to do this.

Aside from the comments and some possible doc updates this feature is good to go!

lua/vgit/git/GitObject.lua Show resolved Hide resolved
lua/vgit/core/Buffer.lua Outdated Show resolved Hide resolved
lua/vgit/features/buffer/LiveGutter.lua Outdated Show resolved Hide resolved
@tanvirtin tanvirtin merged commit 723a443 into tanvirtin:main May 3, 2022
@ibhagwan
Copy link
Contributor Author

ibhagwan commented May 3, 2022

Ty <3

@ibhagwan ibhagwan deleted the buffer_stats branch May 3, 2022 05:00
@nyngwang
Copy link

nyngwang commented May 3, 2022

@ibhagwan Thanks for you too!

@ibhagwan
Copy link
Contributor Author

ibhagwan commented May 3, 2022

@ibhagwan Thanks for you too!

Thx @nyngwang :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API to get diff for statusline
3 participants