fix(git show): allow cwd outside root git dir #334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi tanvirtin,
When cwd is outside of the root git directory, calls to git show fail due to the
./
prefix added to the filename. I believe this is not required, since we should be using a relative filename from the project git root dir and/or setting-C
to self.cwd.To replicate, open any file in a root git directory,
:cd
to some other dir and:VGit buffer_blame_preview
Related to #79