Fix clang-tidy problems

taocpp · Feb 2, 2020 · ccb1ca1 · ccb1ca1
1 parent 61e8b4f
commit ccb1ca1
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/include/tao/pq/connection_pool.hpp b/include/tao/pq/connection_pool.hpp
@@ -36,8 +36,8 @@ namespace tao::pq
       };
 
    public:
-      connection_pool( const private_key& /*unused*/, std::string connection_info ) noexcept
-         : m_connection_info( std::move( connection_info ) )
+      connection_pool( const private_key& /*unused*/, const std::string& connection_info ) noexcept
+         : m_connection_info( connection_info )
       {}
 
       [[nodiscard]] std::shared_ptr< pq::connection > connection()

diff --git a/include/tao/pq/transaction.hpp b/include/tao/pq/transaction.hpp
@@ -39,7 +39,7 @@ namespace tao::pq
       explicit transaction( const std::shared_ptr< pq::connection >& connection );
       virtual ~transaction() = 0;
 
-      virtual bool v_is_direct() const = 0;
+      [[nodiscard]] virtual bool v_is_direct() const noexcept = 0;
 
       virtual void v_commit() = 0;
       virtual void v_rollback() = 0;

diff --git a/src/lib/pq/connection.cpp b/src/lib/pq/connection.cpp
@@ -63,7 +63,7 @@ namespace tao::pq
          }
 
       private:
-         [[nodiscard]] bool v_is_direct() const override
+         [[nodiscard]] bool v_is_direct() const noexcept override
          {
             return true;
          }
@@ -129,7 +129,7 @@ namespace tao::pq
          void operator=( top_level_transaction&& ) = delete;
 
       private:
-         [[nodiscard]] bool v_is_direct() const override
+         [[nodiscard]] bool v_is_direct() const noexcept override
          {
             return false;
          }

diff --git a/src/lib/pq/transaction.cpp b/src/lib/pq/transaction.cpp
@@ -33,7 +33,7 @@ namespace tao::pq
             }
          }
 
-         [[nodiscard]] bool v_is_direct() const override
+         [[nodiscard]] bool v_is_direct() const noexcept override
          {
             return false;
          }