Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Redis 5.0 features, including Streams API #210

Closed
wants to merge 3 commits into from

Conversation

bobby
Copy link
Contributor

@bobby bobby commented Jul 10, 2018

I generated a new commands.edn in order to address #208.

New commands.edn adds commands:

  • XLEN
  • XADD
  • XREADGROUP
  • BZPOPMAX
  • ZPOPMIN
  • XREAD
  • XRANGE
  • XPENDING
  • ZPOPMAX
  • XREVRANGE
  • BZPOPMIN

and changes command:

  • SET

Adds:

- XLEN
- XADD
- XREADGROUP
- BZPOPMAX
- ZPOPMIN
- XREAD
- XRANGE
- XPENDING
- ZPOPMAX
- XREVRANGE
- BZPOPMIN

Changes:

- SET
@hden
Copy link

hden commented Aug 3, 2018

Any update on this?

@tirkarthi
Copy link

Thanks much for the PR @bobby . I wrote a blog post with this PR and things work well. One command I was missing was the XACK command due to which I was not able to acknowledge the messages read by different consumers in a group. I think it will be an useful addition along with XGROUP command for which you have raised an issue upstream command generation from reference.

Thanks

@tirkarthi
Copy link

Thanks much @bobby I have verified the usage of new commands in ca59a6b and they work fine :)

- Includes XINFO after update of PR
@bobby
Copy link
Contributor Author

bobby commented Sep 5, 2018

Okay, I've updated as of adding XINFO to the mix. I've tested locally on a rather complex distributed system, and it works well. @ptaoussanis when are you comfortable merging these changes, after redis/redis-doc#963 is merged, or could we do before?

@ptaoussanis
Copy link
Member

Hi Bobby, sorry for the long delay replying. This looks great, will try merge + cut a new release tomorrow 👍Cheers!

ptaoussanis pushed a commit that referenced this pull request Sep 22, 2018
…@bobby)

Adds:

- XLEN
- XADD
- XREADGROUP
- BZPOPMAX
- ZPOPMIN
- XREAD
- XRANGE
- XPENDING
- ZPOPMAX
- XREVRANGE
- BZPOPMIN

Changes:

- SET
@ptaoussanis
Copy link
Member

Merged and cut [com.taoensso/carmine "2.19.0"], on Clojars now 👍

@tirkarthi
Copy link

Thanks much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants