-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appenders can't be removed using (merge-config! {:appenders {:appender-name nil}}) #163
Comments
Hey Andreas, thanks so much for the detailed report! Have pushed a fix that'll go out with the next Timbre release. In the meantime, your suggestion to use Whatever's most convenient, there's no magic happening underneath; Timbre's config is just a standard map (at Cheers :-) |
Thank you Peter! Yep, the config approach seems simple and super flexible. Good point in using (timbre/swap-config! assoc-in [:appenders :println :enabled?] false) over (timbre/merge-config! {:appenders {:println {:enabled? false}}}) as the former makes the path to the config param more readable. (def set-log-config-param! (partial timbre/swap-config! assoc-in)) and then be even more consise and also compatible with the timbre v3.4.0 set-config! syntax: (set-log-config-param! [:appenders :println :enabled?] false) I wonder if a similar |
Hi Andreas, no problem :-)
Do you think this is a common problem? Is it because new users don't know how to use |
Yeah, I think |
Using [com.taoensso/timbre "4.3.1"] in a fresh project, when I run
I get:
instead of
nil
, as I would expect.Similarly appenders that I add with
merge-config!
can't be removed via
merge-config!
returns:
With regards to disabling (vs. removing) an appender (which seemed to be the problem here [https://github.com//issues/161]), you can still do
I.e.
returns
enabled? false
:as expected.
The text was updated successfully, but these errors were encountered: