Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Move 3rd-party appenders to community #322

Closed
ptaoussanis opened this issue Oct 1, 2020 · 1 comment
Closed

[BREAKING] Move 3rd-party appenders to community #322

ptaoussanis opened this issue Oct 1, 2020 · 1 comment
Assignees
@ptaoussanis
Labels
next breaking release
Milestone
v6

Comments

@ptaoussanis
Copy link
Member

Looks like ClojureScript doesn't like namespace segments starting with a digit. Might be time to move everything under a community namespace?
@ptaoussanis ptaoussanis self-assigned this Oct 1, 2020
ptaoussanis added a commit that referenced this issue Mar 22, 2022
@ptaoussanis
[#322] BREAKING: rename 3rd-party -> community appenders
0b4f1de
ptaoussanis added a commit that referenced this issue Mar 22, 2022
@ptaoussanis
[#322] BREAKING: rename 3rd-party -> community appenders
1f14402
ptaoussanis added a commit that referenced this issue Mar 22, 2022
@ptaoussanis
[#322] BREAKING: rename 3rd-party -> community appenders
58aeda5
ptaoussanis added a commit that referenced this issue Mar 22, 2022
@ptaoussanis
[#322] BREAKING: rename 3rd-party -> community appenders
404d8ac
@ptaoussanis ptaoussanis added this to the v6 milestone Jul 7, 2022
ptaoussanis added a commit that referenced this issue Jul 7, 2022
@ptaoussanis
[mod][#322] BREAKING: rename 3rd-party -> community appenders
fc90a9e
@ptaoussanis
Copy link
Member Author

Marking as done, will be included in forthcoming release 👍

ptaoussanis added a commit that referenced this issue Oct 19, 2022
@ptaoussanis
[mod] [#322] BREAKING: rename 3rd-party -> community appenders
5dcf250
ptaoussanis added a commit that referenced this issue Oct 20, 2022
@ptaoussanis
[mod] [#322] BREAKING: rename 3rd-party -> community appenders
a560a36
ptaoussanis added a commit that referenced this issue Oct 20, 2022
@ptaoussanis
[nop] [#322] Update README
7a37290
ptaoussanis added a commit that referenced this issue Oct 22, 2022
@ptaoussanis
[mod] [BREAKING] [#322 #353] Reorganise community appenders
f11e8d4 
Changes include:

  - [#322] Rename `3rd-party` -> `community`
  - [#353] Exclude from default Lein profiles to help prevent community
    code with strange dependencies and/or environment expectations
    (e.g. Android) from interfering with builds, cljdoc, etc.
ptaoussanis added a commit that referenced this issue Oct 23, 2022
@ptaoussanis
[mod] [BREAKING] [#322 #353] Reorganise community appenders
1c9fbb4 
Before this commit:
  Community appender namespaces: `taoensso.timbre.appenders.3rd-party.X`

After this commit:
  Community appender namespaces: `taoensso.timbre.appenders.community.X`.

This is a BREAKING change for you iff:
  You're using any of the included community appenders.
  In this case, just change `3rd-party` in your ns imports to `community`.

Motivation for change:

  The `3rd-party` namespace segment beginning with a numeric has long
  caused minor issues with tooling, etc. (e.g. #322).

  Took the opportunity to also exclude community code from the default
  Lein profiles to help prevent community code with strange dependencies
  and/or environment expectations (e.g. Android platform) from interfering
  with builds, cljdoc, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptaoussanis ptaoussanis

Labels
next breaking release
Projects
None yet
Milestone
v6
Development

No branches or pull requests
1 participant
@ptaoussanis