Allow args to swap-config! function #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Russell, not silly at all- a convenient change, thank you! |
ptaoussanis
added a commit
that referenced
this pull request
Nov 30, 2015
Add & args to `swap-config!` function (@rsslldnphy)
ptaoussanis
pushed a commit
that referenced
this pull request
Nov 30, 2015
ptaoussanis
pushed a commit
that referenced
this pull request
Dec 13, 2015
ptaoussanis
pushed a commit
that referenced
this pull request
Dec 15, 2015
ptaoussanis
pushed a commit
that referenced
this pull request
Dec 15, 2015
ptaoussanis
pushed a commit
that referenced
this pull request
Dec 22, 2015
ptaoussanis
pushed a commit
that referenced
this pull request
Dec 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so trivial it's a bit silly, but this PR allows
swap-config!to be passed arguments, following the pattern ofclojure.corefunctions such asswap!,alter-var-root,updateetc.The end result is you can write code like this:
rather than:
There aren't any tests for this namespace so I haven't added any for this change, but I've manually tested the function (despite it being very simple) in both Clojure and Clojurescript.