Make callsite-id in log! macro deterministic for Clojure
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the non-deterministic `rand` was used as part of generating `callsite-id` in the `log!` macro at compile time, the compiler would produce non-deterministic bytecode as a result. This thwarts reproducible builds. Instead, use a RNG with a fixed seed. Unfortunately, both the JS standard library and Google Closure's library don't seem to provide a similar facility, so it's only implemented for Clojure.
|
@DerGuteMoritz Hi Moritz, thanks for this! Looks good, will merge when I'm next doing batched work on Timbre 👍 |
|
@DerGuteMoritz Merging manually now, thanks again Moritz! 👍 |
ptaoussanis
pushed a commit
that referenced
this pull request
Oct 18, 2022
…jure (@DerGuteMoritz) Since the non-deterministic `rand` was used as part of generating `callsite-id` in the `log!` macro at compile time, the compiler would produce non-deterministic bytecode as a result. This thwarts reproducible builds. Instead, use a RNG with a fixed seed. Unfortunately, both the JS standard library and Google Closure's library don't seem to provide a similar facility, so it's only implemented for Clojure.
ptaoussanis
pushed a commit
that referenced
this pull request
Oct 19, 2022
…jure (@DerGuteMoritz) Since the non-deterministic `rand` was used as part of generating `callsite-id` in the `log!` macro at compile time, the compiler would produce non-deterministic bytecode as a result. This thwarts reproducible builds. Instead, use a RNG with a fixed seed. Unfortunately, both the JS standard library and Google Closure's library don't seem to provide a similar facility, so it's only implemented for Clojure.
ptaoussanis
pushed a commit
that referenced
this pull request
Oct 20, 2022
…jure (@DerGuteMoritz) Since the non-deterministic `rand` was used as part of generating `callsite-id` in the `log!` macro at compile time, the compiler would produce non-deterministic bytecode as a result. This thwarts reproducible builds. Instead, use a RNG with a fixed seed. Unfortunately, both the JS standard library and Google Closure's library don't seem to provide a similar facility, so it's only implemented for Clojure.
ptaoussanis
pushed a commit
that referenced
this pull request
Oct 22, 2022
…jure (@DerGuteMoritz) Since the non-deterministic `rand` was used as part of generating `callsite-id` in the `log!` macro at compile time, the compiler would produce non-deterministic bytecode as a result. This thwarts reproducible builds. Instead, use a RNG with a fixed seed. Unfortunately, both the JS standard library and Google Closure's library don't seem to provide a similar facility, so it's only implemented for Clojure.
ptaoussanis
pushed a commit
that referenced
this pull request
Oct 23, 2022
…jure (@DerGuteMoritz) Since the non-deterministic `rand` was used as part of generating `callsite-id` in the `log!` macro at compile time, the compiler would produce non-deterministic bytecode as a result. This thwarts reproducible builds. Instead, use a RNG with a fixed seed. Unfortunately, both the JS standard library and Google Closure's library don't seem to provide a similar facility, so it's only implemented for Clojure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the non-deterministic
randwas used as part of generatingcallsite-idin thelog!macro at compile time, the compiler would produce non-deterministic bytecode as a result. This thwarts reproducible builds.Instead, use a RNG with a fixed seed. Unfortunately, both the JS standard library and Google Closure's library don't seem to provide a similar facility, so it's only implemented for Clojure.