Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up the PR workflow #34

Closed
taoning2014 opened this issue Jan 14, 2022 · 1 comment
Closed

Set up the PR workflow #34

taoning2014 opened this issue Jan 14, 2022 · 1 comment
Labels
DevOps What issues belongs to DevOps? https://aws.amazon.com/devops/what-is-devops/

Comments

@taoning2014
Copy link
Owner

Make the PR workflow to be mandatory, banned push code directly to the master branch.
@taoning2014 taoning2014 added enhancement New feature or request DevOps What issues belongs to DevOps? https://aws.amazon.com/devops/what-is-devops/ and removed enhancement New feature or request labels Jan 14, 2022
@taoning2014
Copy link
Owner Author

Set up branch protect rules, however, this feature only prevent developer do a force push. A follow-up investigation is needed.

For reference: here is the current setting:

github com_taoning2014_srt-validator_settings_branch_protection_rules_23804760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DevOps What issues belongs to DevOps? https://aws.amazon.com/devops/what-is-devops/
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taoning2014