TypeError: elem.getAttribute is not a function

[moltar]

Version 3.0.0 (or 3.0.1) seems to intro an error:

TypeError: elem.getAttribute is not a function

const html = parse('...')

// happens here
html.querySelector('#foo')

[moltar]

      at Object.getAttributeValue (node_modules/node-html-parser/dist/matcher.js:11:17)
      at node_modules/css-select/lib/attributes.js:32:28
      at Object.findOne (node_modules/node-html-parser/dist/matcher.js:68:13)
      at node_modules/css-select/lib/index.js:117:27
      at Object.select [as selectOne] (node_modules/css-select/lib/index.js:64:16)
      at HTMLElement.Object.<anonymous>.HTMLElement.querySelector (node_modules/node-html-parser/dist/nodes/html.js:421:29)

...

[taoqf]

I need more details. here is an example of id selector, and the tests passed.

[olitoni]

I've got the same issue

  let root = parse(data);
  let test = root.querySelectorAll('.observed');
  console.log(test[0].querySelector('.search'))
  
  //Returns:
  TypeError: elem.getAttribute is not a function

[olitoni]

Just tried, 2.1.0 works absolutely fine and returns the HTMLElement from the code above

[kika]

For me this error happens when there's no match for the selector.

[moltar]

For me this error happens when there's no match for the selector.

Most likely the same for me. I'm checking for the existence of an element that I expect to be absent most of the time.

[kika]

I got around by using querySelectorAll and checking the length of the result. But I'd expect querySelector to return a falsey value, not a trap.

[taoqf]

I got around by using querySelectorAll and checking the length of the result. But I'd expect querySelector to return a falsey value, not a trap.

May I know what is the html you parsed? I should do some tests and try to fix that.

Just tried, 2.1.0 works absolutely fine and returns the HTMLElement from the code above

It will be easier for me to have the html.

I did some tests like that:

const root = parse('<div class="a b"></div>');
root.querySelectorAll('a').length.should.eql(0);
should.equal(root.querySelector('a'), null);
root.querySelectorAll('.a').length.should.eql(1);
root.querySelectorAll('.b').length.should.eql(1);
should.notEqual(root.querySelector('.a'), null);
const nodelist = root.querySelectorAll('.a,.b');
nodelist.length.should.eql(1);
const div = nodelist[0];
root.querySelector('.a,.b').should.eql(div);

[taoqf]

I tried to fix the issue. If you guys won't give me any clue, I will publish 3.0.2 several hours later.

[taoqf]

I think I fixed the issue. 3.0.3 published.

[taoqf]

Thank all of you.

[kika]

Yeeep, can confirm, now querySelector works as expected if there's nothing in the HTML that matches the selector.

[moltar]

Thanks @taoqf! 🙌🏼