Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: socket close properly #609

Merged
merged 3 commits into from
Mar 9, 2023
Merged

fix: socket close properly #609

merged 3 commits into from
Mar 9, 2023

Conversation

sangshuduo
Copy link
Contributor

No description provided.

huskar-t
huskar-t approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@huskar-t huskar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangshuduo sangshuduo marked this pull request as ready for review March 9, 2023 03:41
facetosea
facetosea approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@facetosea facetosea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangshuduo sangshuduo force-pushed the fix/sangshuduo/TD-23043-windows-socket-close branch from 55622b0 to f210855 Compare March 9, 2023 04:14
@sangshuduo sangshuduo force-pushed the fix/sangshuduo/TD-23043-windows-socket-close branch from f210855 to ee3c5bf Compare March 9, 2023 04:15
@sangshuduo sangshuduo merged commit d03bcfb into develop Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facetosea facetosea facetosea approved these changes

@huskar-t huskar-t huskar-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sangshuduo @facetosea @huskar-t