Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatted entire codebase using black; merged new and old workflows. #45

Merged
merged 5 commits into from Oct 15, 2022
Merged

Conversation

hitblast
Copy link
Contributor

Things changed:

  • The whole codebase has been formatted using the black code formatter.
  • A new job has been combined with the existing linting workflow to format code using black.
  • Fixed job names in lint.yml and renamed to lint-and-format.yml.

@hitblast hitblast added the enhancement New feature or request label Oct 15, 2022
@hitblast hitblast self-assigned this Oct 15, 2022
Copy link
Collaborator

@furtidev furtidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hitblast hitblast merged commit c67fc5e into taotnpwaft:main Oct 15, 2022
Copy link
Member

@gbowne1 gbowne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taotnpwaft/discord-bot

Make sure you only trigger the workflow when necessary, especially so we don't hit limits.

There is a way to not run workflows on every PR.. I forget how to do that. I don't know if we need workflow runs on every single PR.

Otherwise this looks good.

The group rules also require a minimum of two reviews that include checked out and tested code and a syntaxial review of code for typos, etc before merging is allowed

So dont just LGTM. We do this to prevent large projects from accumulating large amounts of bugs and untested code.

Merging right away is allowed only if your merge is part of a bigger feature and if you have tested and linted your code and your PR will have no significant affect on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants