add close method to store

taoyuan · Aug 27, 2013 · 9aced6a · 9aced6a
1 parent e1e8fbc
commit 9aced6a
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 3 deletions.
diff --git a/lib/adapters/redis.js b/lib/adapters/redis.js
@@ -155,4 +155,9 @@ Redis.prototype.clear = function (pattern, callback) {
     });
 };
 
+Redis.prototype.close = function (cb) {
+    this.client.quit();
+    if (cb) process.nextTick(cb);
+};
+
 
diff --git a/lib/store.js b/lib/store.js
@@ -75,4 +75,15 @@ Store.prototype.bucket = function (namespace) {
         this.buckets[namespace] = c;
     }
     return c;
+};
+
+/**
+ * Close store connection
+ */
+Store.prototype.close = function close(cb) {
+    if (typeof this.adapter.close === 'function') {
+        this.adapter.close(cb);
+    } else if (cb) {
+        cb();
+    }
 };
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "kvs",
-  "version": "0.0.1-3",
+  "version": "0.0.1-4",
   "description": "Simple key-value store facade for node.",
   "main": "index.js",
   "scripts": {

diff --git a/test/common-bucket.js b/test/common-bucket.js
@@ -30,18 +30,22 @@ module.exports = function (getStore) {
     function testKvs(name, genValue, options) {
 
         context('bucket ' + name, function () {
+            var store;
             var bucket;
             var key;
             var value;
 
             beforeEach(function () {
-                bucket = getStore().crateBucket(support.random.string(), options);
+                store = getStore();
+                bucket = store.crateBucket(support.random.string(), options);
                 key = support.random.string(20);
                 value = genValue();
             });
 
             afterEach(function (done) {
-                bucket.clear(done);
+                bucket.clear(function () {
+                    store.close(done);
+                });
             });
 
             describe('get() and set()', function () {