Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2.5] Proguard is not working #17

Closed
mirland opened this issue May 22, 2019 · 6 comments
Closed

[2.2.5] Proguard is not working #17

mirland opened this issue May 22, 2019 · 6 comments

Comments

@mirland
Copy link

mirland commented May 22, 2019

The sdk doesn't work if Proguard is enabled, you can take a look at xmartlabs@0325ee7

@HaithamSheshtawy
Copy link
Collaborator

Maybe the reason is one of two:

If you have an older installation on your phone(with a debug key), please uninstall it first. (You can't have the same app with two different signatures on your device)

Assuming you're keeping ADT up to date.
If you're building the release version of your application using Eclipse export, it will load Proguard settings from the file specified by the proguard.config property in project.properties.

If you are using ant release, it will load the Proguard settings from the file specified by the proguard.config property in ant.properties.

That being said, are you getting any kind of errors or warnings during your build? These are especially helpful when diagnosing Proguard since it's purpose is to remove classes and methods that it doesn't think are being used by your application.

@HaithamSheshtawy
Copy link
Collaborator

HaithamSheshtawy commented May 23, 2019

The key to fixing the build is looking at the build output messages, understanding what the warnings are about and addressing them, usually by fixing your dependencies or adding -dontwarn rules to your ProGuard config.

You can refer to https://medium.com/androiddevelopers/troubleshooting-proguard-issues-on-android-bce9de4f8a74

@mirland
Copy link
Author

mirland commented May 23, 2019

You have problems in TAP-GLKIt android dependency, I think it's using reflection. You should define these rules in the sdk documentation, I think it's not a application issue.

If you run my sample application you will see a crash.
Thanks!

@mirland
Copy link
Author

mirland commented Jun 24, 2019

Have you defined these rules? I think this shouldn't be closed until the library defines the rules Here you can see an example of one of the biggest library on android

@Haitham001
Copy link

Haitham001 commented Jun 25, 2019 via email

@mirland
Copy link
Author

mirland commented Jul 4, 2019

this is not fixed, so it should be reopened, please test it. I added the solution in #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants