fix: type cast error #1468
Merged
fix: type cast error #1468
+129
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ply0011
requested changes
Nov 6, 2023
| @@ -495,8 +495,12 @@ private static Object convert(Object value, String newDataType) { | |||
| value = convertNumber(value, s -> new BigDecimal(s).longValue()); | |||
| break; | |||
| case "DATE": | |||
| DateTime dateTime = AnyTimeToDateTime.toDateTime(value); | |||
| value = dateTime.toDate(); | |||
| if (value instanceof String) { | |||
ply0011
requested changes
Nov 7, 2023
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } |
| * Example input: {"value": "DateTime nano 0 seconds 1327149189 timeZone null", "newDateType": "Date"} | ||
| * Expected output: IllegalArgumentException(DateTime constructor illegal dateStr: value) | ||
| */ | ||
| @Test(expected = RuntimeException.class) |
| } else { | ||
| DateTime dateTime = AnyTimeToDateTime.toDateTime(value); | ||
| value = dateTime.toDate(); | ||
| } |
There was a problem hiding this comment.
提供更好的异常信息，例如：日期类型转换失败，字段名：xxx，原始类型: String，原始值：xxx
ply0011
approved these changes
Nov 8, 2023
jackin-code
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.