Feat cloud send mail limit develop #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiliang110100
requested review from
jackin-code,
ply0011 and
xbsura
as code owners
ply0011
requested changes
Nov 15, 2023
| @@ -494,7 +492,10 @@ private boolean sendMail(AlarmInfo info, AlarmMessageDto alarmMessageDto, UserDe | |||
| Settings prefix = settingsService.getByCategoryAndKey(CategoryEnum.SMTP, KeyEnum.EMAIL_TITLE_PREFIX); | |||
| AtomicReference<String> mailTitle = new AtomicReference<>(title); | |||
| Optional.ofNullable(prefix).ifPresent(pre -> mailTitle.updateAndGet(v -> pre.getValue() + v)); | |||
| MailUtils.sendHtmlEmail(mailAccount, mailAccount.getReceivers(), mailTitle.get(), content); | |||
| if(!settingsService.isCloud() || messageService.checkMessageLimit(userDetail) < MailUtils.CLOUD_MAIL_LIMIT){ | |||
There was a problem hiding this comment.
- 这个判断出现多次，是否可以封装一下？
- CLOUD_MAIL_LIMIT这个常量作为默认值，最好提供一个环境变量的修改入口
ply0011
approved these changes
Nov 17, 2023
jackin-code
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.