Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --save-dev to install instruction #166

Merged
merged 1 commit into from
Jul 21, 2015
Merged

Added --save-dev to install instruction #166

merged 1 commit into from
Jul 21, 2015

Conversation

mathiasrw
Copy link
Contributor

My 2 cents...

@troutowicz
Copy link

Not everyone that installs tape plans on developing tape.

@ghost
Copy link

ghost commented Jul 21, 2015

@troutowicz: this would install tape as a devDependency, not a dependency in package.json. I think that is what most people will want.

@ljharb
Copy link
Collaborator

ljharb commented Jul 21, 2015

Although I personally don't use the save options on npm install, since it messes with my package.json formatting, I think including them as a default is the appropriate thing to do for the majority of users. This LGTM.

@mathiasrw
Copy link
Contributor Author

👍

1 similar comment
@wavded
Copy link

wavded commented Jul 21, 2015

👍

Raynos added a commit that referenced this pull request Jul 21, 2015
Added --save-dev to install instruction
@Raynos Raynos merged commit c388972 into tape-testing:master Jul 21, 2015
@mathiasrw mathiasrw deleted the patch-1 branch July 21, 2015 21:56
@troutowicz
Copy link

this would install tape as a devDependency

Oops... 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants