Travis: Add Node v4 #195
Merged
Travis: Add Node v4 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbinnssmith
changed the title
|
I don't see any reason to remove |
|
Hm. When node hits 5 (which it will in the coming months iirc), "node" will simply move onto 5 (unless travis decides to keep node pointing to the latest LTS instead of the latest node) and 4 will become untested. Either way, I imagine it will be best to be explicit. See browserify's patch. |
|
¯_(ツ)_/¯ not sure what node LTS has to do with an arbitrary library's chosen support level. I don't mind putting |
|
I second that its still useful to keep |
I imagine the entry "4" will continue to be the latest stable release of the 4.x line on travis.
wbinnssmith
force-pushed
the
patch-1
branch
from
01d280b
to
df62458
Compare
|
All right, the patch simply adds "4" now. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I imagine the entry "4" will continue to be the latest stable release of the 4.x line on travis.