Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] notEqual and notDeepEqual show "expected" value on failure. #454

Merged
merged 1 commit into from
Dec 28, 2018
Merged

[Fix] notEqual and notDeepEqual show "expected" value on failure. #454

merged 1 commit into from
Dec 28, 2018

Conversation

JoshuaGrams
Copy link
Contributor

Closes #453.

ljharb
ljharb requested changes Dec 22, 2018
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great to include regression tests with this, so it doesn't break in the future.

@JoshuaGrams
Copy link
Contributor Author

OK, try this. But you had better check over my code: I just copied test/deep-equal-failure.js and adapted it: I'm not sure I fully understand how it works.

ljharb
ljharb approved these changes Dec 28, 2018
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, thanks!

@ljharb ljharb merged commit 9ced991 into tape-testing:master Dec 28, 2018
ljharb added a commit that referenced this pull request Dec 29, 2018
@ljharb
v4.9.2
a1e8f7e 
 - [Fix] notEqual and notDeepEqual show "expected" value on failure (#454)
 - [Docs] Updated readme to make test, test.only, and test.skip consistent (#452)
 - [Docs] Clarify doesNotThrow parameters (#450)
 - [Docs] Adding tap-junit (#449)
 - [readme] Change broken image to use web archive (#443)
 - [Docs] convert list of tap reporters to links (#439, #440)
 - [Dev Deps] update `eslint`, `eclint`
@ljharb ljharb mentioned this pull request Jan 9, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoshuaGrams @ljharb