Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug (with solution PR): Video Category's Chevron Icons update late based on click event #628

Closed
1 task done
abhiram11 opened this issue Feb 17, 2023 · 1 comment · Fixed by #629
Closed
1 task done
Assignees
Labels
bug Something isn't working

Comments

@abhiram11
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Note: I have also issued a Pull Request based on this Bug, please consider it after inspecting this bug report. Thanks!

The Category scroll bar does not update (hide/show) its ChevronRightOutline or ChevronLeftOutline as scrolling is done by updating the useRef.

Here's how the UI Normally looks:
Issue

Here's how it looks after we click on > ONCE, the Red box indicates that the < icon should already be visible now:
Issue1

Here's how it looks RIGHT AFTER we reach the end of the scroll list, the red box indicates that the > icon should already disappear now:
Issue2

Expected Behavior

The expected behavior (as also shown as a solution in my PR) is that the < and > icons are displayed correctly and not after one more (unnecessary) click event to be done to update/re-render the UI.

This is how the proposed solution in my PR looks like:

The URL shows the difference between the current behavior (lenstube) and the expected behavior (localhost)

2023-02-18.02-57-54.mp4

Steps To Reproduce

The original website currently shows the same behavior, kindly click on the > and < of the category section to see the bug.

What platform(s) does this occur on?

Web

What browser(s) does this occur on?

Chrome

Anything else?

No response

@abhiram11 abhiram11 added bug Something isn't working needs review Review required labels Feb 17, 2023
@sasicodes sasicodes removed the needs review Review required label Feb 18, 2023
@sasicodes
Copy link
Member

Great catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants