Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Post&Comments&Likes API, bugfixes #5

Merged
merged 23 commits into from
Jan 20, 2016

Conversation

AutomatedPlayground
Copy link
Contributor

No description provided.

@AutomatedPlayground
Copy link
Contributor Author

Added new search options

@@ -627,6 +781,83 @@ public void run() {
mTestController.log("Tests finished correctly", false, false);
}
});

// alternate search test #1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit this or enable this as a test. There's no reason to have so much dead code.

@@ -45,9 +52,10 @@
* Type of cache object - to be used to determine type of generic API object inside requests
*/
public enum TGCacheObjectType {
Connection(1), ConnectionUser(2), ConnectionUserList(3), Event(4), EventObject(5), Feed(6),
Connection(1), ConnectionUser(2), ConnectionUserList(3), Event(4), EventObject(5), EVENTSLIST(6),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename EVENTSLIST to EventList to be consistent with all the other declarations.

@dlsniper
Copy link
Contributor

Please also make sure you format the code accordingly before the next update. Also, please rebase this on master as there have been some updates. Thank you.

@AutomatedPlayground
Copy link
Contributor Author

Rebase done. For formatting - I changed what I saw from my updates. Code after your changes in version 1 is non-automatic-formatable for me. When I do automated format from Android Studio it fixes almost all lines which would cause many conflicts if you work asynchronously with me ;)
We can do full format of code and commit after making sure, that all is commited and merged from your and mine side.

dlsniper added a commit that referenced this pull request Jan 20, 2016
Added support for Post&Comments&Likes API, bugfixes
@dlsniper dlsniper merged commit 9fb6cea into tapglue:master Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants